search

tlverse / tmle3shift

🎯 :game_die: Targeted Learning of the Causal Effects of Stochastic Interventions
https://tlverse.org/tmle3shift
GNU General Public License v3.0
16 stars 1 forks source link

Loose test against classic implementation #16

Closed nhejazi closed 6 years ago

nhejazi commented 6 years ago

The txshift package provides an implementation of this same estimation procedure in the case of a simple shift (i.e., shift_additive) without reliance on tmle3 machinery. The independent procedure is used as the basis for this test, which has been loosened as of f83eabf. This test was previously passing under the (original) more stringent criteria as of 355c29f. It seems rather unlikely that a change in this package would have caused this test to break (since no commits near or after 355c29f altered shift_additive); instead, it's likely this was caused by updates to dependencies, which do not currently run reverse dependency checks. This should be further investigated.

jeremyrcoyle commented 6 years ago

I'll make a PR to fix this real fast