tlverse / tmle3shift

🎯 :game_die: Targeted Learning of the Causal Effects of Stochastic Interventions
https://tlverse.org/tmle3shift
GNU General Public License v3.0
16 stars 1 forks source link

Disable cvtmle in specs #17

Closed jeremyrcoyle closed 6 years ago

jeremyrcoyle commented 6 years ago

This resolves https://github.com/tlverse/tmle3shift/issues/16

In https://github.com/tlverse/tmle3/pull/25 the default for tmle3 changed from standard to cv-tmle, as the cv-tmle implementation is now stable, and has better asymptotic properties. This PR overrides that default in all the tmle3shift specs to standard tmle. This allows tests to match output from txshift. This fixes the test, but reverts tmle3shift to using standard tmle everywhere. Long term, we should have re-enable cv-tmle for tmle3shift by default, and only use standard tmle for comparison with older packages and where it makes sense in simulation.