tlx02 / pe

0 stars 0 forks source link

Opencom behaviour is not specified #7

Open tlx02 opened 2 years ago

tlx02 commented 2 years ago

Steps to reproduce: type "opencom 2"

Actual: The second commission of the currently open customer is shown. However, the user guide did not state that the index is the index of the commission in the commission list for the currently open customer. This is confusing for customers.

nus-se-bot commented 2 years ago

Team's Response

Hi, we believe that this is not an issue for the following reasons. Below is the user guide for the command in question:

image.png

  1. For opencom, there is an image in our user guide for opencom 2, where the picture shows that it is the 2nd commission in the list that is opened. Thus, there is a picture to show that 2 refers to the 2nd commission in the list.
  2. It is completely false that the index is the index of the commission in the commission list for the currently open customer. We have an allcom command that shows the commission for all customers, and opencom can also be used to open those in the commission list. Thus, the index is the index of the commission list, and to adopt this suggestion for our UG would make our UG wrong.
  3. The fact that "com" is in the name of the command suggests that the index is for the commission list. Otherwise, what is opencus for then?
  4. There is an additional explanation for the term Index in the glossary. It would explain how to get the index of a commission.

image.png

  1. On page 13 of our user guide, we do mention what commissions can be shown in the commission list. (e.g selected customer by default) image.png

Also, this seems like a critique for our UG, so I am not sure why this is labelled a Medium FunctionalityBug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]