tlx02 / pe

0 stars 0 forks source link

Opencom is allowed at the customer page #8

Open tlx02 opened 2 years ago

tlx02 commented 2 years ago

Steps to reproduce: 1) ensure that you are at the customer page 2) type opencom 2

Actual: Opens the second commission of the open customer

This is not intuitive and does not seem to make sense since the user is unable to view the list of commissions at the customer page. Hence users could be confused as to whether the index refers to the customer or the commission.

nus-pe-bot commented 2 years ago

Team's Response

Hi!

This is a feature, not bug, of ArtBuddy. We took this deliberate design choice because ArtBuddy is designed for fast typists who want to get things done fast. We don't want to restrict users by imposing an unnecessary constraint.

Addressing the 2 issues brought up:

1. This is not intuitive and does not seem to make sense since the user is unable to view the list of commissions at the customer page.

Yes, users cannot view the list of commissions at the customer tab. But, they may remember the indexes of the commissions. Consider the case where a user switches to the customer page to check some detail of the selected customer real quickly before performing some commission command on a commission.

The user still remembers the commission index because it's still fresh in his/ her mind, or he/ she had already stored it in his brain- because he/ she knows he's/she's going to use that index very soon. By allowing users to perform commission commands in the customer tab, this user can easily perform his commission command without having to switch back to the commission tab (without incurring an additional command).

In addition, the opencom command would switch the user to the Commission View, so the user can immediately see the outcome of their command. That is another reason why we think it is alright to run it from the customer tab.

I hope this makes it clearer why we deliberately made it so that commission-commands may be executed in the customer tab.

2. Users could be confused as to whether the index refers to the customer or the commission.

Also, we don't really think this is a major concern. It is highly unlikely users will mess up the indexes because the commands explicitly remind you whether you are manipulating a customer or commission anyway, that's why its opencus and opencom.

Furthermore, there isn't really a major problem with accidentally using the wrong index since open commands don't do anything irreversible. So, we felt that the pros of allowing opencom commands at the customer tab outweigh the cons.

Hope this answers to your concerns, and explains why we don't consider being able to open commissions in the customer tab a feature flaw.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]