search

tm9k1 / stegano

Bit-level Image Concealing App built with Qt Framework - Steganography Pet Project
9 stars 3 forks source link

Linux distributions are very large #2

Closed EndrII closed 4 years ago

EndrII commented 4 years ago

Hi i see your deployment documentation. You are using allQmDepends parameters. But this option added unnecessary qml libraries. Remove this deployment command parameter and redeploy the project.

cqtdeployer -bin stegano  -qmldir ~/steganography/Steganography/ -targetDir ~/release/
tm9k1 commented 4 years ago

oh! Thanks a lot for sharing, @EndrII ! I have never packaged any Qt project, this was a first for me. 😅 I'll fix that as soon as I can.

EndrII commented 4 years ago

thanks )

tm9k1 commented 4 years ago

Hi again @EndrII ! I just tried the command, but it didn't bring along all the deps. Please take a look at the attached screenshot.

linux error

I got the exact same issue while releasing (without the flag allQmlDependes) on Windows as well.

EndrII commented 4 years ago

You are using the wrong qmldir option. not qmldir but qmlDir

cqtdeployer -bin myApp -qmlDir /path/to/my/qml/files -recursiveDepth 3 -targetDir ~/release/

And please add -recursiveDepth 3 parameter to recursively find qml files from path/path/to/my/qml/files

tm9k1 commented 4 years ago

ah! so it didn't pick up on the qmlDir flag at all! It still made the release, wow! I'll fix this in the wiki and make a new release ASAP. The build size was halved when I tried this a couple minutes ago. Crazy! P.S: @EndrII I see a contribution opportunity here. Would you mind if I add a check to CQtDeployer for erroring when an unidentified flag (like -qmldir) is passed?

EndrII commented 4 years ago

@taskmaster9001 thanks you. i am very happy of any help. when i looked at this post i thought the same thing. We need to add support for displaying invalid options. I will create a task for you, where I will describe what and how best to do,

tm9k1 commented 4 years ago

Great! Looking forward to it ^_^

On Sat, Oct 3, 2020 at 1:08 PM Andrei Yankovich notifications@github.com wrote:

@taskmaster9001 https://github.com/taskmaster9001 thanks you. i am very happy of any help. when i looked at this post i thought the same thing. We need to add support for displaying invalid options. I will create a task for you, where I will describe what and how best to do,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/taskmaster9001/stegano/issues/2#issuecomment-703062237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPOMM4ON3TEFDDHCRBOBA3SI3IGFANCNFSM4SBROAVA .

EndrII commented 4 years ago

it is done ) see this issue