Scikit learn instead of sklearn

[eyadsibai]

https://github.com/tmadl/semisup-learn/blob/82ad804b3f7472d89ae629c3c689c5920edce006/setup.py#L10

I believe this should be scikit-learn instead of sklearn

[plbecker]

The short name of the Scikit-Learn package (which you'll use to import it) is 'sklearn'

[eyadsibai]

I agree but when I want to install this package it won't work! pip install git+https://github.com/tmadl/semisup-learn won't install the right package

[plbecker]

Works for me. Does it say Collecting scikit-learn (from sklearn->semisup-learn==0.0.1) during the installation process? You may want to update pip if it can't find scikit-learn via sklearn

[eyadsibai]

it is installing a package called sklearn!! then sklearn package requires scikit-learn it is a different package. there is already a package called sklearn. This is not working as intended. Go check the documentation of scikit-learn and how it should be installed. No other project uses sklearn in the requirements.txt Read the project description please! https://pypi.org/project/sklearn/

[plbecker]

I am aware of this, but you should still be able to install it via sklearn. It is planned to remove this functionality (https://github.com/scikit-learn/scikit-learn/issues/8215), but it should still work. Why don't you submit a PR if you want to change it?

[eyadsibai]

part of open source contribution is to submit such issues. Not necessary submitting PRs. If you don't like this issue, then thank you, though u r not the owner nor the contributor of this repo.

[plbecker]

though u r not the owner nor the contributor of this repo.

Thanks for pointing that out, I didn't know!

[lesteve]

FYI I have opened #10 to fix that.