Closed sympmarc closed 3 months ago
@sympmarc Thanks for your contribution!
The filenames in the baselines
folder don't match the references in the tenant settings file (settings_template.yml
). As you've described, this could lead to confusion.
For now, there are two options to reference a baseline from the tenant settings file:
.yml
suffix); e.g. M365.IAM.1-2.1
id
which is contained in the baseline; e.g. M365.1-2.1
It doesn't matter which option you choose.
But to make it clearer from an end user perspective, I think we should add this to the documentation here (directly on the develop
branch):
https://github.com/tmaestrini/easyGovernance#tenant-settings-file
@sympmarc My bad – you were right: the reference must match filename of the .yml
file in the baselines
folder (or wherever you set the reference to). Therefore, I've changed the definitions in the settings_template.yml
.
Hoping that the confused guinea pig now is eating green grass again... 😃
🐹
The baselines listed in
settings_template.yml
don't match the filenames in thebaselines
folder. I still think getting up and running is a bit confusing - and I'm a good guinea pig for that.Is it the intention that if the filenames in the
baselines
folder change, then they should also change insettings_template.yml
? The ps1 files likesrc\Private\Validation\Test-M365.1-1.1.ps1
also seem to have to match thebaselines
filenames. It feels a bit brittle to me.