search

tmaiaroto / hugo-redlounge

A Hugo theme
Other
100 stars 65 forks source link

Use .Site.Title and .Site.Params.description… #6

Closed halostatue closed 2 years ago

halostatue commented 10 years ago

…if .Site.Params.sidebartitle and .Site.Params.sidebartagline are not set.

This makes it so that h1#brand-title is always visible.

halostatue commented 10 years ago

Implemented per #4.

tmaiaroto commented 10 years ago

I actually didn't want the <h1> or <h2> element on the page at all if there was no title. There's padding/margin that pushes things around should someone not want the text or not want the subtitle. This could make the spacing between whatever is there and the navigation a little awkward.

Of course users can simply overwrite the template partial for more complex needs...It would be quite valid to say that I may be going overboard with options. =)

halostatue commented 10 years ago

Hmm…I think I may adapt that idea in hugo-cabaret and make it so that there’s a partials/sidebar_brand.html. That way it can be implemented the way that I’m doing it (forcing <h1>, but <h2> requires either the sidebar or the site description) and it’s easy to override. I like the number of partials that you have, which is part of why I’m starting to build on what you’ve done.

tmaiaroto commented 10 years ago

Sounds good. Watch for that sidebar when it comes to responsiveness. Different things start to fit. I added some media queries to change font size at different window sizes, but it's a fixed panel without scroll...So it can get tricky.