search

tmaier / docker-compose

Container with Docker + Docker Compose - good for CI
https://hub.docker.com/r/tmaier/docker-compose/
MIT License
152 stars 50 forks source link

python3 support #11

Closed fergyfresh closed 4 years ago

fergyfresh commented 6 years ago

Hey, i don't know much about this, but I'm trying to use your container to do the following.

docker-compose up
pip install -r requirements.txt
python -m unittest

I know this isn't much to go off of, but i noticed the latest docker build on dockerhub uses python2.7 and was wondering if you could point me in the right direction of making this python3.6 compatible provided you think its possible.

tmaier commented 5 years ago

Related PR #12

tmaier commented 5 years ago

The use case you are describing works, but is unintended. See similar discussion on #3

ollisal commented 4 years ago

Python2 has reached end-of-life and docker-compose upstream is currently removing support for it: https://github.com/docker/compose/issues/6890

Current docker-compose also has some annoying bugs when used with Python2, e.g. https://github.com/docker/docker-py/issues/2425.

Thus, changing to python3 sooner rather than later would be a good idea for docker-compose usage alone.

ollisal commented 4 years ago

My fork of another similar Docker image, tiangolo/docker-with-compose, at https://github.com/JaksoSoftware/docker-with-compose uses Python 3.8. It's available as python3 inside the container.

Published as ollisal/docker-with-compose

tmaier commented 4 years ago

@ollisal can you open a pull request?

tmaier commented 4 years ago

@ollisal your link does not work. Can you open a pull request?