search

tmakin / RhinoCommonUnitTesting

Example of unit testing RhinoCommon from within the Visual Studio test runner on windows
35 stars 14 forks source link

Feature/xunit adaptation #2

Closed marios-tsiliakos closed 4 years ago

marios-tsiliakos commented 4 years ago

Xunit adaptation for Rhino Geometry tests

tmakin commented 4 years ago

@marios-tsiliakos Many thanks for this. Looks like a useful addition.

But please can you remove the MigrationBackup from the PR. I can see you have edited the gitignore to try and block them, but it looks it sneaked in before that.

I'd also prefer to switch to the newer SDK csproj format if adding a new project. Happy to help with that if needs. https://natemcmaster.com/blog/2017/03/09/vs2015-to-vs2017-upgrade/

marios-tsiliakos commented 4 years ago

Hi @tmakin ,

Wow that was super fast. I just noticed a discrepancy in the naming of the project and namespace which I fixed in my forked copy.

Let me know if it makes any sense of amending this.

Thanks again for sharing the testing solution in the first place.

tmakin commented 4 years ago

If it builds fine then leave it - the project is only an example anyway. I should probably go back in and update my original version to SDK format at some point and then I can review namespaces at the same time.

marios-tsiliakos commented 4 years ago

Yep, builds fine.

Sounds good thanks.