search

tmakkonen / sipcmd

sipcmd
327 stars 108 forks source link

permissive build on Ubuntu 12.10 server #6

Closed kalabiyau closed 11 years ago

kalabiyau commented 11 years ago

Hey, Tuomo !

On 

Ubuntu 12.10 x86_64
gcc 4.7.2
libopal  3.10.4
libpt 2.10.4

sipcmd will compile only with -fpermissive which, i suppose, not valid behavior

edholland commented 11 years ago

Confirmed issue on debian wheezy with same package versions. Error shown below

src/channels.h: In constructor ‘TestChannel::TestChannel(OpalConnection&, TestChanAudio&)’: src/channels.h:112:35: error: cast from ‘TestChannel’ to ‘unsigned int’ loses precision [-fpermissive] src/channels.h: In destructor ‘virtual TestChannel::~TestChannel()’: src/channels.h:116:59: error: cast from ‘TestChannel’ to ‘unsigned int’ loses precision [-fpermissive]

edholland commented 11 years ago

i believe i have fixed this in my fork. Although i cant have two open pull requests so the fix will have to wait until the previous pull request has been reviewed :)

tmakkonen commented 11 years ago

I merged your previous pull request, ready to receive a new one :-)

edholland commented 11 years ago

my mistake, the changes got pulled in with that request, see commit 9bc3078 I believe this issue is now fixed. Please confirm and close :)

tmakkonen commented 11 years ago

Confirmed!