Adjusting `--low-rank` can overflow or segfault for some values

tmaklin / cpprate

Reimplementation of the variable selection via RATE method https://github.com/lorinanthony/RATE

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Adjusting `--low-rank` can overflow or segfault for some values #20

Open tmaklin opened 7 months ago

tmaklin commented 7 months ago

The default value for --low-rank is min(n_observations, n_snps). Using values lower than the default can cause overflows in the results, and using values larger than the default segfaults for some cases.

Solve this by

Preventing running with values outside of sensible range
... and/or fix the numerical stability if the algorithm is meaningful for values lower than the default (investigate).
Figure out what is segfaulting in the larger than defaults.

tmaklin commented 3 months ago

it seems like removing the option to adjust is the best way to proceed