search

tmalsburg / helm-bibtex

Search and manage bibliographies in Emacs
GNU General Public License v2.0
464 stars 74 forks source link

Update bibtex-completion.el for parsebib.el 6.0 #453

Closed joostkremers closed 1 week ago

joostkremers commented 2 weeks ago

As I mentioned in issue #452 , I've made some changes to the parsebib.el API that affect bibtex-completion.el. This PR fixes those issues. Obviously, it shouldn't be merged until I push the new parsebib.el to master.

I've only changed the relevant function calls. Given the purpose of bibtex-completion.el, it would probably make sense to use parsebib-collect-bib-entries and parsebib-collect-strings, but that would require a bigger change (e.g., parsebib-collect-bib-entries can do some of the things that bibtex-completion-prepare-entry does, it seems), so you probably have a better idea if that's worth it.

tmalsburg commented 2 weeks ago

Thank you for this PR. I'll merge it when you give me the green light.

joostkremers commented 2 weeks ago

Thanks. I'd like to merge the new parser some time over the weekend. I'll let you know when I do.

joostkremers commented 1 week ago

I've just merged the new parser and pushed to Github.

tmalsburg commented 1 week ago

Merged. Thank you!!