Put AbsSpect under units management

tmancal74 / quantarhei

Open Quantum System Theory for Molecular Systems

MIT License

21 stars 16 forks source link

Put AbsSpect under units management #5

Closed tmancal74 closed 8 years ago

tmancal74 commented 8 years ago

AbsSpect class has several methods which need to be put under units management.

calculate(rwa) needs to understand rwa in current units
plotting needs to react to frequency units

tmancal74 commented 8 years ago

Plotting of AbsSpect of a monomeric molecule now reacts to energy_units (frequency_units) needs to be implemented as yet DFunction of frequency argument also works with changing units of energy

tmancal74 commented 8 years ago

calculate(rwa) now understands energy_units context manager

tmancal74 commented 8 years ago

frequency_units and energy_units context managers are now made identical. This is a design decision. It would be very difficult to make a consistent choice about two different scopes of usage for energy and frequency when they are essentially the same thing. The issue can bow be closed