search

tmancal74 / quantarhei

Open Quantum System Theory for Molecular Systems
MIT License
21 stars 16 forks source link

Implement Plottable class #50

Open tmancal74 opened 6 years ago

tmancal74 commented 6 years ago

Use it in DFunction, CorrelationFunction, SpectralDensity and AbsSpectrum and other classes to control plotting.

tmancal74 commented 1 year ago

It seems to me to make more sense to implement a Plotter object that would be able to plot the objects occurring in Quantarhei, rather than implement plotting methods in individual classes.

Advantages: 1) the classes would not contain a difficult-to-test code (which the plotting part always is). All Matplotlib code would be concentrated into one class or subpackage. 2) One can remove the dependency of Quantarhei on Matplotlib (one dependence less is good) 2) In principle, this could also be an independent package.

tmancal74 commented 1 year ago

I leave the issue open for now, but soon I will create a new issue to get rid of the Matplotlib dependency. I will also create a new project (something like QrheiPlotter, or QPlotter)