tmanderson / VintageLines

[RETIRED] Relative line numbers for Sublime Text 2's Vintage package
47 stars 16 forks source link

Make the icons the same width as the normal line number gutter #38

Open leonardt opened 10 years ago

leonardt commented 10 years ago

When changing between insert and normal mode, the screen jumps as the width of the gutter in the different modes are different. It's a bit jarring, would it be possible to have the widths be consistent?

joshuaconner commented 10 years ago

+1

gregsabo commented 10 years ago

+1

benwoodward commented 10 years ago

+1

sheerun commented 10 years ago

Totally

ghost commented 10 years ago

so is this ever going to be done? Or even better to have normal numbers instead of images.

markalfred commented 10 years ago

So the problem is that the relative line numbers are drawn in the designated "icon" area of the line (the same place "marks" are drawn via cmd+F2, or where GitGutter draws its icons see: #37). Then, it just completely disables the normal line-numbers via

self.view.settings().set('line_numbers', False)

So this is a fundamental issue with the plugin — and likely why the author refers to it as "janky". It's clever, but it means that this will likely never be implemented unless someone finds a way to have these line numbers replace the normal ones.

Has anyone ever seen any plugin that affects the line numbers themselves in any way? That might be the key to getting this feature.

silouanwright commented 9 years ago

+1

avegancafe commented 9 years ago

Is there any way to set the font of the new ones? if we can set the font and width of the gutter, it would effectively do the same thing

jasjuang commented 8 years ago

+1