search

tmanderson / ivona-node

Ivona Cloud (via Amazon services) client library for Node
32 stars 5 forks source link

Error is thrown when using proxy #2

Closed stsvilik closed 8 years ago

stsvilik commented 8 years ago

Looks like you forgot to require("http") and attempt to use it.

tmanderson commented 8 years ago

I've updated the proxy code, though not using http. As https as the primary protocol for this particular module. Thanks for this.

stsvilik commented 8 years ago

using https on proxy that only accepts http (most common case) there will be an error thrown as well. I tried it in your code and I got error about an attempt to connect on wrong port and connection got refused. So using http in this case is preferred. Maybe you should make it configurable (i.e. https: true)