search

tmarenko / GenshinImpact_PaimonShutUp

Automatically mutes Paimon when she speaks
Apache License 2.0
38 stars 3 forks source link

Paimon and Cyno #11

Closed olibeniron closed 1 year ago

olibeniron commented 1 year ago

Hello! Same person who'd first suggested adding more languages for the programm. I've been using your tool since then, and it truly brought me peace. However, with Sumeru release, there seemed to be a little problem with name recognition. It wasn't as pronounced until I touched upon Cyno's personal quest, now it gets in the way.

Cyno and Paimon names spelled very similar in Russian "Паймон | Сайно" so the tool mistakes them and mutes Cyno on many occasions. Is it possible to overcome it? I've been switching game to English whenever Cyno turns up in quests, but that's not the best solution since my reading speed significantly drops that way.

tmarenko commented 1 year ago

Are you playing with low resolution maybe? The Levenshtein difference between "Паймон" and "Сайно" is 3 and currently the script allows only 2 errors in the name. So could be Tesseract is recognizing Cyno's name with errors as well. Anyway, at least I should have check the difference by Paimon's name, so it's fixed in https://github.com/tmarenko/GenshinImpact_PaimonShutUp/commit/303d437aa48823250bd4ada030dbb0d936d11760

Please try new build: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/4963033165

If this won't help then I could make the "how many wrong letters is allowed" varible (by lowering overlap param) into the config file. So you could have more strict rules to catch only "Paimon" text.

olibeniron commented 1 year ago

My resolution is 1920x1080 fullscreen with 16:9 screen ratio. Thank you, I'll try the new build today.

olibeniron commented 1 year ago

Ah, no, it still mutes him as well. Even more vigorously than before.

tmarenko commented 1 year ago

I lowered allowed errors in https://github.com/tmarenko/GenshinImpact_PaimonShutUp/commit/795285fbd1cafe7ad634e7d7e95e1bf896a9335e

Please try new build: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/4971602069

If this won't help I'll check Russian translation manually on my PC. And probably will think about adding unit-tests for different languages and character names.

olibeniron commented 1 year ago

So far it works! I'll continue to observe it through the questline, but the latest build seemed to fix the problem. I'll report how it went at the end of the day.

olibeniron commented 1 year ago

Yes, it no longer mistakes Paimon and Cyno and works flawlessly. Thank you very much for the fix.

tmarenko commented 1 year ago

Added as configuration option in https://github.com/tmarenko/GenshinImpact_PaimonShutUp/commit/4aac275397282c6cfe5bf904fe31da73242bbd74 Released in 1.5.0