tmarenko / GenshinImpact_PaimonShutUp

Automatically mutes Paimon when she speaks
Apache License 2.0
38 stars 3 forks source link

latest version #6

Closed monte91 closed 2 years ago

monte91 commented 2 years ago

Just saw this and it seemed amazing, but unfortunetly it dosn''t work. It just says ready for paimon and game closed when i close the game. Maybe the game files blocked it or something, any tips? win10, 3080ti, running in fullscreen/windowed with 1 monitor.

tmarenko commented 2 years ago

What's your in-game screen resolution?

monte91 commented 2 years ago

3,840 by 2,160

monte91 commented 2 years ago

i evn tried 1080p windowed still nothing

tmarenko commented 2 years ago

What's language for text/UI are you using in the game? Script only works for eng version e.g. when Paimon's name is Paimon

tmarenko commented 2 years ago

Tested latest release and it works for me. Win10, 3070, fullscreen 1 monitor at 1080p, eng language image

monte91 commented 2 years ago

i'ts english and using 1 monitor

monte91 commented 2 years ago

I tried 1080p full/win, taking off admin access/re adding it, maybe i need a set of drivers for the program?

tmarenko commented 2 years ago

No, it should work with default DirectX capture. Script probably can't capture the game properly or fails to recognize Paimon's name in cutscenes. I can make a debug version of the script in order to find out what's happening. If you want to test it

monte91 commented 2 years ago

I would appreciate it, thank you.

tmarenko commented 2 years ago

I've added debug branch: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/compare/main...debug Build: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922618159 Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969356444/artifacts/340753519

Run it while talking to any NPC or Paimon (for example you can spawn her in your Serenitea Pot) When you run exe file you should see a debug window like this: image

On top left you can see a cropped image that goes into OCR. Somewhere in the middle you can see red and green rectangle. Usually one of them should contain NPC's name.

Also, debug window copies it's data to debug.png file as well.

tmarenko commented 2 years ago

Also please try this build https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922700683 Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969564015/artifacts/340765734

It uses BitBlt function instead of PrintWindow to capture game image

monte91 commented 2 years ago

Also please try this build https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922700683 Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969564015/artifacts/340765734

It uses BitBlt function instead of PrintWindow to capture game image

It didn't cap the name debug

tmarenko commented 2 years ago

Check your display settings in Windows. Do you have more than 100% scale? If so try with 100% image

I've added debug branch: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/compare/main...debug Build: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922618159 Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969356444/artifacts/340753519

Did the first build work for you?

monte91 commented 2 years ago

I used the 2nd build and it works, but is there a way to configure it to work with 200% scaling?

tmarenko commented 2 years ago

Yes, it's possible to make an application DPI aware so it'll properly capture with any scale. Already made required changes: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/compare/main...dpi_aware Build (in progress, need to wait): https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2926759286

monte91 commented 2 years ago

Cool, thank you

tmarenko commented 2 years ago

Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7979797769/artifacts/341497334 Let me know if it works for you

monte91 commented 2 years ago

yay it works, do you have a patreon or something?

tmarenko commented 2 years ago

Fix released in https://github.com/tmarenko/GenshinImpact_PaimonShutUp/releases/tag/1.2.0

yay it works, do you have a patreon or something?

Hah, no, I don't =) happy to help you