Url encode spaces - Githubissues

tmarois / laravel-ads-sdk

PHP SDK for Google Ads, Bing Ads, and Facebook Ads API for Laravel

MIT License

113 stars 46 forks source link

Closed modernben closed 3 years ago

modernben commented 3 years ago

When the scope is https://ads.microsoft.com/ads.manage offline_access some IDE's don't allow for clicking the whole url.

timothymarois commented 3 years ago

Nice catch!

I wonder if it would also work to use rawurlencode to get any other characters?

modernben commented 3 years ago

You could but then it would convert all characters to their entity equivalent.

So https:// would turn to https%3A%2F%2F. Not super friendly to look at.

timothymarois commented 3 years ago

True. I'll get this into the next release!

Feel free to join our Discord channel