Allow non-root directories to save models.

tmastny / leadr

https://tmastny.github.io/leadr/

MIT License

26 stars 2 forks source link

Allow non-root directories to save models. #12

Closed tmastny closed 6 years ago

tmastny commented 6 years ago

This affects to_list, which takes the directory name given in the leaderboard tibble. It can only find it if it is in the root directory.

tmastny commented 6 years ago

Note that board can save to non-root subdirectories just fine, as demonstrated in the directory unit tests: https://github.com/tmastny/leadr/blob/master/tests/testthat/test-aaa-directory.R#L18

Thinking this through, is this even an enhancement/bug? board saves the leaderboard path globally, and the model folders must be subdirectories of that path.

[ ] add a unit test to to_list to see if it can find models in non-root directories. Possibly add this to directory tests for connivence

tmastny commented 6 years ago

[ ] The default directory to save and create new directories should not be root, but something like models.

The question is, how will leadr know where the directory is between sessions.