I'd appreciate a review of this before I push it up, particularly from @dentarg, since he worked hard on getting 5.8 going.
I decided to align 5.8 with existing work in addition to bringing the scripts-5.8 work back into the fold. While in there, it seemed to be I could go back to using the install script to create the Vagrant user and put it into the appropriate groups. I think it is better to use the install script to do things it already does well.
I believe this refactor doesn't change the built box in any material way. Please let me know if you see differently.
dentarg
commented
8 years ago
I'd appreciate a review of this before I push it up, particularly from @dentarg, since he worked hard on getting 5.8 going.
I decided to align 5.8 with existing work in addition to bringing the
scripts-5.8work back into the fold. While in there, it seemed to be I could go back to using the install script to create the Vagrant user and put it into the appropriate groups. I think it is better to use the install script to do things it already does well.I believe this refactor doesn't change the built box in any material way. Please let me know if you see differently.