search

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

OS detection fails on vagrant 1.7.2 / windows #110

Closed timidri closed 5 years ago

timidri commented 9 years ago

See https://github.com/tmatilai/vagrant-proxyconf/blob/master/lib/vagrant-proxyconf/action/configure_env_proxy.rb#L44:

def windows_guest?
  @machine.config.vm.guest.eql?(:windows)
end

This test fails on vagrant 1.7.2 / windows because @machine.config.vm.guest.eql?(:windows) returns false. while vagrant succesfully autodetects the OS to be windows.

tmatilai commented 9 years ago

Ah, this was written before Windows guest support was included into Vagrant core. We should now ask the guest type directly from Vagrant (and fallback to this on older Vagrant versions).

timidri commented 9 years ago

Yes, i tried to find in the documentation how to do it so I could offer a pull request, but no luck. :-(

codylane commented 5 years ago

Closing out this issue case windows support seems to be working. Please re-open if this is still an issue and provide details on how to reproduce.