tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Missing HTTPS_PROXY for Docker #116

Closed Diaoul closed 9 years ago

Diaoul commented 9 years ago

See here: https://github.com/tmatilai/vagrant-proxyconf/blob/master/lib/vagrant-proxyconf/action/configure_docker_proxy.rb#L75-L90

Diaoul commented 9 years ago

Nevermind, that doesn't seem necessary for docker to pull images properly. Somehow I thought it was used when building docker images (for example apt-get inside a Dockerfile which vagrant has to build) but it seems for that I have to send the env variables to the containers manually.

Am I correct?

otahi commented 9 years ago

I think you are correct.

I think http_proxy is enough to use https docker repository outside proxy. See docker func newClient. And a docker container is separated from its host. If you need to use proxy environment variables on docker containers, you need to send them manually.

Diaoul commented 9 years ago

Thanks