tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

[WIP]Support systemd #137

Closed otahi closed 4 years ago

otahi commented 8 years ago

Because #114 is stopped, I have duplicate the pull request and add modifications.

I will add more description for this pull request, soon.(Added by @otahi at 2015-10-15 06:35:17 +0900)

Some Linux distributions use systemd as alternative a system management daemon. Systemd can pass environment variables services which launched by systemd. If proxy configuration changes, target guests to be restarted.

Systemd is major in these days. We need to test following distributions at least.

CC/@flaccid, @dimafujitsu

flaccid commented 8 years ago

I did a basic test with Arch Linux and it is ok for system proxy conf. One small improvement would be to ensure /etc/profile.d/proxy.sh is executable. For Docker however, /etc/default/docker is being configured which is incorrect. For systemd/docker on arch this needs to be per https://wiki.archlinux.org/index.php/Docker#Daemon_Proxy_Configuration using the Environment directive in the unit file.

otahi commented 8 years ago

@flaccid Thank you for your quick response. I am very appreciated!!

Do you mean "Docker doesn't work with EnvironmentFile=-/etc/default/docker on Arch Linux?" Other Linux distributions which use systemd work good, I think..

Can you give me an image URL which I can test for?

Anyone can fix small improvements by pull requests. I am waiting for that. :smiley:

flaccid commented 8 years ago

@otahi I'm working on this now but its probably more of a medium sized improvement :) Using /etc/default/docker would be frowned upon for archlinux. From reading around people are preferring to simply use Environment in the override unit file.

flaccid commented 8 years ago

For Arch Linux, here is information on proxies in Docker: https://wiki.archlinux.org/index.php/Docker#Proxies (could still do with enhancement/changes) and base boxes for Vagrant: https://wiki.archlinux.org/index.php/Vagrant#Base_Boxes_for_Vagrant.

otahi commented 8 years ago

@flaccid Thank you for your information. I will check it.

codylane commented 4 years ago

I apologize but I cannot understand this pull request and it is very old. If this is still a problem please let us know. Thanks.