Authenticated proxy URLs with some special characters cause invalid environment variables

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies

MIT License

531 stars 74 forks source link

Authenticated proxy URLs with some special characters cause invalid environment variables #140

Closed jeffastorey closed 5 years ago

jeffastorey commented 8 years ago

If you configure your http proxy to use an authenticated proxy url like http://<username>:<password>@<myproxy>, the HTTP_PROXY and HTTPS_PROXY environment variables are set as expected. If the password contains a value like a ( or ) it causes an invalid environment variable because that environment variable needs to be quoted. I'm not sure the exhaustive list of characters that need to be quoted.

n3integration commented 8 years ago

:+1: - ran across the same issue

vboerchers commented 7 years ago

This issue should is resolved with #152

codylane commented 5 years ago

Please re-open if this is still and issue. Closing for now.