search

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Docker config is invalid #142

Closed rlaveycal closed 8 years ago

rlaveycal commented 8 years ago

Docker (at least, v1.9.1) requires that values in the config file are enclosed in quotes. The current code doesn't do this, resulting in a corrupt file that prevents docker from starting.

otahi commented 8 years ago

@rlaveycal I am very very appreciated to your pull request!!

I have checked docker documentation https://github.com/docker/docker/commit/d53b586ff1b274b529b7912df3052a1bc2ca8dfe . And it seems that double quotations are required for http_proxy environment variables at least docker 1.4.

I could not found any change around http_proxy environment. Can you give some information about docker's change?

I want to check the issue in my environment, please give some information how you reproduce the issue(OS, version, and more).

rlaveycal commented 8 years ago

I'm using Ubuntu 14.04 (trusty) with Docker 1.9.1. I'm not a linux/docker person, just using it for an eval project so just going by the comment in the default file.

otahi commented 8 years ago

@rlaveycal I have checked http_proxy environment variables on Ubuntu 14.04 (trusty) with Docker 1.10.1(Installation). It seems docker works with environment variables.

I want to confirm that you have no trouble on your environment and just want to fix the requirement violation. Is it right?

rlaveycal commented 8 years ago

Yes, Once I enclose the values in double quotes in the docker file everything works. Without them docker won't start.

otahi commented 8 years ago

I have checked it works on my environment. Thank you for your pull request!