Initial add of Windows system proxy settings

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies

MIT License

531 stars 74 forks source link

Initial add of Windows system proxy settings #143

Closed mynamewastaken closed 8 years ago

mynamewastaken commented 8 years ago

@rlaveycal I used your code for this, I hope that's ok.

@tmatilai This is still WIP, just wanted to get the PR made to solicit feedback. I plan to test this in the next few days.

Sorry about the mention spam, accidentally made the 1st PR against my own copy.

mynamewastaken commented 8 years ago

@tmatilai This does appear to work! I took a screenshot (http://imgur.com/taaTOEA) where that was set exclusively by the vagrant-proxyconf plugin - nothing external.

mynamewastaken commented 8 years ago

Will rebase and squash when I get home.

tmatilai commented 8 years ago

@mynamewastaken wanna squash? I'm fine merging this trusting you it's working. =)

mynamewastaken commented 8 years ago

@tmatilai squashed!

tmatilai commented 8 years ago

Great, thanks a lot!