tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Add support to dnf (Fedora) #147

Open r1w1s1 opened 8 years ago

r1w1s1 commented 8 years ago

Hi,

Please add the support of DNF(next generation of yum) the file name changes /etc/dnf/dnf.conf but the option still the same.

proxy=http://mycache.mydomain.com:3128 proxy_username=yum-user proxy_password=qwerty

Cheers,

relief-melone commented 5 years ago

3 years later still nothing on this? It's definately pretty painful to always provision the dnf.conf manually

codylane commented 5 years ago

@relief-melone - I'm not sure I understand your unhelpful response to this issue.

It's not helpful to an open source project when someone demands that an issue be addressed. Open source is about the community and relying on the community to help enable this ecosystem to be a better place by contributing ideas and time to address issues and features.

As you may or may not know, the open source community is not paid for their time. A project like this is also supported on many, many operating systems and it lot to manage a project like this.

You are very much welcome to contribute to this plugin and we do accept pull requests as long as the integration is well tested and doesn't change the code behavior in a bad way.

If you are a developer and have time to contribute then great, please submit a pull request. If you are not a developer then I guess we will just have to wait until this feature is prioritized by someone who has the time to address this issue or it becomes a large enough issue throughout the community that it needs to addressed.

I'm sure there are a lot of folks that use fedora and would love to see this addressed but like I said it comes down to time and contributions by others.

I know this code base well enough to address this issue but just because I can doesn't mean I should. I am not a feature monkey and don't just put features in because people ask. I'll spend time on an integrations if it makes sense and if I can support it. The current code base already takes a lot to support so adding new integrations may not make sense without further help.

kumattau commented 10 months ago

@codylane

l send PR #243 to fix yum and support dnf. Could you check it ?