Incorrect format being written to /etc/environment

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies

MIT License

531 stars 74 forks source link

Incorrect format being written to /etc/environment #159

Closed akumria closed 5 years ago

akumria commented 7 years ago

In debugging why vagrant-proxyconf wasn't working, I stumbled over the fact that the output it generates for /etc/environment is incorrect.

See http://man7.org/linux/man-pages/man5/pam_env.conf.5.html

Unfortunately https://github.com/tmatilai/vagrant-proxyconf/blob/c87058dac3a50ef7f38cad3e94f30d4ffcb72582/lib/vagrant-proxyconf/config/env_proxy.rb#L49 appears to prefix values with 'export'.

tmatilai commented 7 years ago

Hmm, that should not be the case. The export should only be output to /etc/profile.d/proxy.sh. /etc/environment is generated by this method which doesn't add the export.

So maybe the issue is somewhere else? What shell do you use on the box?

codylane commented 5 years ago

This shouldn't be a problem anymore due merge. Closing.

Feel free to re-open if it's still an issue.