search

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Apt proxy verify host #193

Closed greut closed 5 years ago

greut commented 5 years ago

An attempt to add the following proxy options to APT. Any helps would be much appreciated.

Acquire::https::Verify-Host "false";
Acquire::https::Verify-Peer "false";
codylane commented 5 years ago

Thank you for your contribution. I'll need some time to digest this pull request and or do an official code review.

At first pass, i'm good with this and thank you for writing tests. ;)

@tmatilai - Do you have any additional thoughts or concerns?

greut commented 5 years ago

@codylane at the end of the day I did that with a small shell provisioner. Take it only if you feel it's actually useful. It feels quite hackish.

codylane commented 5 years ago

hi @greut - Thanks again for reporting this. I've not had the time to look into this issue much further and I apologize.

I just wanted to confirm that I understand this issue correctly, do the changes you are requesting help support the case when you are behind a proxy that terminates ssl and without these settings apt cannot install packages or do updates?

greut commented 5 years ago

@codylane indeed, a proxy that also is a mitm. An happy corporate setup we've got here :)

codylane commented 5 years ago

Awesome, thanks for the response. I'm going to try and get this in the 2.0.2 release. I hope to have some time this week.

codylane commented 5 years ago

Hey - Status update and I apologize for the delay. I should have some extra free time in the next couple of weeks to get this in and I've made a few changes to those core libraries which would probably make this pull request to be a little behind. Since this is my fault for not merging this in sooner i'll take care of this problem.

I appreciate you taking the time to put this in and write tests. :)

I'll make sure this gets into the 2.0.3 release.

codylane commented 5 years ago

Hi @greut - I'm closing out this pull request since it's my fault this is out of date. I'll be tracking this change via #199. I plan to give you full credit for this in the release changelog. I apologize for for the delay.