tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Support git and svn configuration #49

Closed tmatilai closed 10 years ago

tmatilai commented 10 years ago

Builds on top of @johnbellone's #40.

Docs are missing, and the action classes (as all other action classes) would benefit from better testing. But in my manual testing this seems to work. @johnbellone, could you also give it a spin?

johnbellone commented 10 years ago

Kick me later today/tonight if I haven't tested :).

tmatilai commented 10 years ago

/me pokes @johnbellone ;)

johnbellone commented 10 years ago

Ah thanks! We've got hit with some snow. I'm building a few machines now I'll grab this :).

tmatilai commented 10 years ago

I'm merging this now, as I have planned some refactoring and want to avoid extra work for resolving conflicts. We can anyway fix the possible issues with this later.

johnbellone commented 10 years ago

@tmatilai Sorry been in transit/conference for a few days. This looks good to me! If there are any issues I'll send PRs in.

jscti commented 10 years ago

Hi

I can't find a way to make SVN work with proxyconf. What am I missing ? In my bootstrap.sh provision file I make a :

agt-get install subversion

In another provisionning file ('cause git/svn seems to be configured by the plugin after each provisionner), a svn co obvisouly fails :( When i installed nodejs/npm, NPM got configured automatically.

For Git, I had also to force it :

git config --global http.proxy $http_proxy

Thanks

otahi commented 10 years ago

Hi @bixibu ,

I have tried to understand by myself. I did not know how to configure Subversion and Git on vagrant-proxyconf.

There is no description for svn and git on README.md. But we can set like this.

  config.proxy.http = "http://10.0.2.2:3128/"
  config.svn_proxy.http = "http://10.0.2.2:3128/"
  config.git_proxy.http = "http://10.0.2.2:3128/"

If you cannot solve by this, we need more detail of the phenomenon.

Thanks,

otahi commented 10 years ago

I added documentation for Git and Subversion on #86. @bixibu

jscti commented 9 years ago

Thanks both config.svn_proxy.http and VAGRANT_SVN_HTTP_PROXY works