search

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Add support for npm proxy #50

Closed hexmode closed 10 years ago

hexmode commented 10 years ago

Another cli app that couldn't be bothered to support $http_proxy.

$ npm config set proxy http://proxy.company.com:8080 $ npm config set https-proxy http://proxy.company.com:8080

tmatilai commented 10 years ago

Hi @hexmode,

Thanks for the suggestion. The strange thing is that the documentation claims that the env vars would be used. And I trusted it without testing. But searching through the issues and code hints that the docs are lying. :/

The support should be quite easy to add if we require that npm is in the PATH. I'll give it a try.

tmatilai commented 10 years ago

@hexmode, PR #51 should do it. Would be nice if you could give it a try. Instructions for installing from git can be found in the wiki.

hexmode commented 10 years ago

worked.