search

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Add docker CoreOS support #80

Closed otahi closed 10 years ago

otahi commented 10 years ago

Add support CoreOS to vagrant-proxyconf docker function. This is indicated in #74.

This modification is based on #75. Only c31a4ba is added to #75.

It has been tested and the result is OK.

otahi commented 10 years ago

@tmatilai Thank you for checking!

I think this logic is OK, because systemctl is a user tool which is in systemd package. It can be run by a vagrant user to show system information.

[vagrant@localhost ~]$ cat /etc/redhat-release
CentOS Linux release 7.0.1406 (Core)
[vagrant@localhost ~]$ rpm -ql systemd | grep /usr/bin/systemctl
/usr/bin/systemctl
[vagrant@localhost ~]$ systemctl show sshd.service | grep SubState
SubState=running
[vagrant@localhost ~]$
tmatilai commented 10 years ago

OK, it's just inconsistent as the command is then invoked with sudo. But let's trust there will be no problems here.

otahi commented 10 years ago

@tmatilai How about this pull request? Can you accept it? I want you to merge if you can accept this pull request, and release vagrant-proxyconf(1.4.0?).

Docker support has been proposed since May 30th 2014. There are several docker related issues in these days(#72, #74, #83 except my pull requests).

I want to use docker supported vagrant-proxyconf as a normal vagrant plugin. I will appreciate if you give a schedule for the next release.

tmatilai commented 10 years ago

@otahi I'm very sorry for my inactivity. But the PR seems good, so merging it in.

otahi commented 10 years ago

@tmatilai Thank you for merging!! :smile:

I will wait for the release of 1.4.0.