search

tmatilai / vagrant-proxyconf

Vagrant plugin that configures the virtual machine to use proxies
MIT License
531 stars 74 forks source link

Add documentation for Git and Subversion #86

Closed otahi closed 9 years ago

otahi commented 10 years ago

I have added missing documentation for Git and Subversion. On #49, I found missing documentation.

otahi commented 10 years ago

@tmatilai Can you check this? I can merge this by myself, but I want you to check.

tmatilai commented 10 years ago

I have a feeling that these were left undocumented at least partly on purpose. In most cases the environment variables should be enough. These extra setting should only be needed if you want to use different proxy settings for git/svn than for the rest of the system. This should be mentioned somehow.

Other issue is that the readme is already too bloated...

otahi commented 10 years ago

@tmatilai, I think svn uses its own settings stackoverflow:How to configure a HTTP proxy for svn. Git can use $http_proxy/$https_proxy, so it is OK to set $http_proxy/$https_proxy.

I agree with you about README is too bloated..

I will try to rewrite.

otahi commented 9 years ago

Hi @tmatilai,

I have summarized the explanation. Please check it.

tmatilai commented 9 years ago

Thanks, looks good!