search

tmatta / lsasim

Simulate large scale assessment data
6 stars 5 forks source link

Improve warning messages on cluster summary() #43

Closed wleoncio closed 3 years ago

wleoncio commented 3 years ago

I tried example 6 

set.seed(4388)
n <- c(cnt = 1, sch = 2, stu = 5)
cg <- cluster_gen(n = n, n_X = 10, c_mean = c(0.3, 0.4, 0.5, 0.6, 0.7))

Then I tried summary(cg) And got the following warning messages image

It seems like all three warning messages are the same. What does the error message mean? Does each message indicate an individual warning for each stage? Maybe we could make it more clear to help users understand where they get these warnings (differently)

Originally posted by @Hugo-v587 in https://github.com/tmatta/lsasim/issues/12#issuecomment-846692343

wleoncio commented 3 years ago

Dear @Hugo-v587,

Which version of lsasim are you using? On 2.0.2.9009 (the latest one on the develop branch) I cannot reproduce the issue. This is my output:

image

Hugo-v587 commented 3 years ago

My package version is 2.0.2.9009. I couldn't reproduce the issue at this time. That's weird... I got the same output as you had. So it seems like this issue is resolved.

wleoncio commented 3 years ago

Alright, thanks for your feedback. Feel free to reopen if you find a way to reproduce it.