search

tmauldin / mb-unit

Automatically exported from code.google.com/p/mb-unit
0 stars 0 forks source link

Gallio Bundle does not compile on systems with Visual Studio 2010 installed and 2008 not #845

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Compile Gallio v3 with no VS 2008

2. Get a problem when building the bundle - 
\v3\build\modules\Bundle 
Package\image\bin\VisualStudio\Gallio.VisualStudio.Shell.* files are not there, 
even though they got built and are in the "VisualStudio.Common" module dir.

Solution:
Make "VisualStudio100.module" explicitly include output from 
VisualStudio.Common, just like it is done in "VisualStudio90.module". 

Patch for v3 attached.

Original issue reported on code.google.com by zla...@gmail.com on 11 Jun 2011 at 2:08

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by Yann.Tre...@gmail.com on 11 Jun 2011 at 7:20

GoogleCodeExporter commented 9 years ago 
Actually, I think we should move those rules to the common module instead and 
drop them from the vs2008 module.

Original comment by jeffbr...@google.com on 13 Jun 2011 at 7:31

GoogleCodeExporter commented 9 years ago 
Of course this way of fixing was because I took VisualStudio90.module approach 
for a representative in such a case.
I am still new to Gallio's conventions so you guys will know better.

Just keep in mind that the files in question already come from a common module 
'VisualStudio.Common.module' that the two already include using:

  <ItemGroup>
    <Module Include="VisualStudio.Common.module" />
  </ItemGroup>

Maybe you just need to inherit its output?

  <ItemGroup>
    <Module Include="VisualStudio.Common.module">
        <Inherit>true</Inherit>
    </Module>
  </ItemGroup>

It worked for me but I couldn't find many uses of <Inherit> besides bundling, 
so I didn't go for it.

Original comment by zla...@gmail.com on 13 Jun 2011 at 8:07

GoogleCodeExporter commented 9 years ago

Original comment by Yann.Tre...@gmail.com on 14 Jun 2011 at 5:48

GoogleCodeExporter commented 9 years ago

Original comment by Yann.Tre...@gmail.com on 14 Jun 2011 at 5:49