search

tmaximini / generator-ionic-gulp

A Yeoman generator for fast hybrid app development that stays out of your way
134 stars 36 forks source link

Add support to wiredep to inject bower dependencies #21

Closed nadouani closed 8 years ago

nadouani commented 8 years ago

It would be nice to add support for wiredep tool to make adding CSS and JS dependencies easier. Actually, using the vendor.json file is really not a convenient way. BTW, how we can include bower dependencies CSS files?

Thanks

tmaximini commented 8 years ago

I had bad experience in the past with wiredep but I am open to give it another try. You are right that the vendor.json is not the most elegant way to handle things. For handling CSS imports I still use the old "save and rename to .scss and import" way - but there are other soulutions such as https://github.com/chriseppstein/sass-css-importer.

JonathanWi commented 8 years ago

Hey @tmaximini , great starter, but I do 100% agree with @nadouani regarding wiredep. Handling a vendor.json, which in turn is just a manual duplicate of bower.json just feels wrong. Would it be possible to have the choice between both?

Thanks a lot

tmaximini commented 8 years ago

I'll look into it when I find the time - I also accept your Pull Requests if you have a working solution ;)

tmaximini commented 8 years ago

let me know if everything works for you with wiredep in 1.4.0

nadouani commented 8 years ago

Thanks, I'll give it a try

JonathanWi commented 8 years ago

Thanks, Same here, will keep you updated!