Adds the `description` and `show_description` options to `Choice` and `InquirerControl`

tmbo / questionary

Python library to build pretty command line user prompts ✨Easy to use multi-select lists, confirmations, free text prompts ...

MIT License

1.57k stars 90 forks source link

Adds the `description` and `show_description` options to `Choice` and `InquirerControl` #330

Closed viniciusdc closed 10 months ago

viniciusdc commented 1 year ago

What is the problem that this PR addresses?

closes #269 ...

How did you solve it?

I am including a new show_description boolean value into the InquirerControl class to allow a new choice attribute called description to be displayed at the bottom of the terminal window -- Similar execution as the current show_selected attribute.

More details in the linked issue. ...

Checklist

[x] I have read the Contributor's Guide.
[ ] I will check that all automated PR checks pass before the PR gets reviewed.

viniciusdc commented 1 year ago

Hi @pmeier, I know you were also interested in this addition. Feel free to push and update the PR as needed.

viniciusdc commented 1 year ago

Hi @kiancross, sorry for the delay with the PR. Would you mind approving the CI tests to run? Thanks in advance 😄

viniciusdc commented 11 months ago

Hi @kiancross, sorry for the constant pings. I just wanted to know if you could have a look into this whenever you have some time 😄 Happy holidays 🎄

pmeier commented 10 months ago

@kiancross Maintainer action is required to run CI:

kiancross commented 10 months ago

CI is running now. But some of the tests are failing.

pmeier commented 10 months ago

@kiancross could you approve CI again and take another look? Locally, everything is passing for me after 9305d578db0b989f2eefb9880d3f6db413eaa818.

pmeier commented 10 months ago

@kiancross Anything left to do now that CI is passing or can this be merged?

kiancross commented 10 months ago

Merged! Thanks for your work on this :)