Open tmc opened 6 years ago
Any update on this?
@TvdBrink I'm sure we could get it in -- I think some test coverage would be in order. Do you think you could assist with that?.
@tmc yes of course. Any preference on using third party packages in tests?
Also, is there any chance we could incorporate the ping and pong handlers of gorilla web socket as in the chat example?
That sounds like a good example to express. My preference is to just use stdlib for testing (but maybe go-cmp for the comparison helper).
Alright, I will make two PR's soon.
@tmc @TvdBrink
Hi, it seems that upstream integration is a no-win situation as of now?
May I ask why grpc_gateway is unwilling to merge this?
Thanks in advance.
I'd like to get this merged into the gateway as it's very closely related to it.