search

tmc / grpc-websocket-proxy

A proxy to transparently upgrade grpc-gateway streaming endpoints to use websockets
MIT License
553 stars 72 forks source link

Propose upstream integration. #11

Open tmc opened 6 years ago

tmc commented 6 years ago

I'd like to get this merged into the gateway as it's very closely related to it.

TvdBrink commented 4 years ago

Any update on this?

tmc commented 4 years ago

@TvdBrink I'm sure we could get it in -- I think some test coverage would be in order. Do you think you could assist with that?.

TvdBrink commented 4 years ago

@tmc yes of course. Any preference on using third party packages in tests?

Also, is there any chance we could incorporate the ping and pong handlers of gorilla web socket as in the chat example?

tmc commented 4 years ago

That sounds like a good example to express. My preference is to just use stdlib for testing (but maybe go-cmp for the comparison helper).

TvdBrink commented 4 years ago

Alright, I will make two PR's soon.

tamama commented 9 months ago

@tmc @TvdBrink

Hi, it seems that upstream integration is a no-win situation as of now?

May I ask why grpc_gateway is unwilling to merge this?

Thanks in advance.