search

tmc / grpc-websocket-proxy

A proxy to transparently upgrade grpc-gateway streaming endpoints to use websockets
MIT License
553 stars 72 forks source link

enable transparent cookie forwarding #12

Open naggie opened 6 years ago

naggie commented 6 years ago

My implementation replies on using a cookies to authenticate websocket connections and normal HTTP RESTful endpoints with a mux used to convert the cookies to metadata.

I believe that this is suitable configuration for the grpc-websocket-proxy project as it makes the websocket-based requests more consistent with the standard HTTP based requests (which have cookies available) at the GRPC gateway.

It also allows the use case of creating a cookie based mechanism to inject metadata; I simply added an interceptor to convert a specific cookie into GRPC metadata.

I don't think it introduces a security risk, as handling cookies is deferred to the GRPC gateway code itself.

Thanks for the websocket gateway, it's made developing a web app that consumes my GRPC API much easier.

naggie commented 6 years ago

Thinking about this again -- is there any reason why the headers are filtered in the first place?