tmc / grpc-websocket-proxy

A proxy to transparently upgrade grpc-gateway streaming endpoints to use websockets
MIT License
553 stars 72 forks source link

Fix websocket proxy subprotocol on IE and Edge #13

Closed le-qi closed 5 years ago

le-qi commented 5 years ago

When creating a Websocket connection on IE and Edge browsers using the JavaScript API, passing the string of protocols unfortunately creates a comma-separated list of the sub-protocols WITHOUT spaces in the Sec-Websocket-Protocol header for the upgrade request (Bearer,token) while Firefox and Chrome have the header string separated with a comma and a space (Bearer, token). Changing the code to accommodate both.

tmc commented 5 years ago

Thanks for your contribution.