search

tmc / langchaingo

LangChain for Go, the easiest way to write LLM-based programs in Go
https://tmc.github.io/langchaingo/
MIT License
4.48k stars 611 forks source link

embeddings: clean up code using new inferaces/type #379

Open eliben opened 10 months ago

eliben commented 10 months ago

374 introduced NewEmbedder which can be used to clean up much of the code in the embeddings package, following #372

This is a tracking issue for that work.

eliben commented 10 months ago

396 is retrofitting TEI into this pattern

tmc commented 10 months ago

@eliben was TEI the last instance? are we good to close?

eliben commented 10 months ago

Nope there's still huggingface, I think you and @zivkovicn worked on it (based on git log). It'd be nice to retrofit that into the new pattern as well.

eliben commented 10 months ago

There are a few more details here: https://github.com/tmc/langchaingo/issues/388#issuecomment-1836818255

tmc commented 10 months ago

There are a few more details here: #388 (comment)

Ah thanks, I had missed that comment. Closing that issue as we have a tagged release but will leave this issue open.

eliben commented 9 months ago

@tmc and @zivkovicn any chance one of you wants to take a look at the huggingface embeddings implementation to make it work with this refactoring so we can close the issue?

I have almost no experience working with Hugging Face