Closed wangjiancn closed 2 weeks ago
@wangjiancn Thank you for this PR. I was also adding WithHTTPClient
option with #840 . I will close my PR, but would ask whether you would like to take over the unit test I added for the scenario from my PR?
@wangjiancn Thank you for this PR. I was also adding
WithHTTPClient
option with #840 . I will close my PR, but would ask whether you would like to take over the unit test I added for the scenario from my PR?
Sure, I'll take a moment to incorporate the test case. I've just been handling the configuration, and I understand it should work without issues.
@skrishnan-sap
github.com/tmc/langchaingo v0.1.10 => github.com/wangjiancn/langchaingo v0.1.11-dev3
looking forward to this PR!
@wangjiancn would love to see this get over the line!
@tmc I've updated the PR, could you please review it? The related code has been used in the production environment, so please help to merge it first.
Just a quick note: I'll be happy to review this PR, but am on vacation now and will be back in about a week. Hopefully it can wait until then
It looks good to me!
Support
github.com/google/generative-ai-go/genai
option.ClientOption
:Fixe: #838
PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.