tmc / langchaingo

LangChain for Go, the easiest way to write LLM-based programs in Go
https://tmc.github.io/langchaingo/
MIT License
4.38k stars 597 forks source link

[llms] Fix ErrIncompleteEmbeddings Message Typos #872

Closed wgeorgecook closed 3 months ago

wgeorgecook commented 3 months ago

PR Checklist

This PR fixes two typos in the ErrIncompleteEmbeddings message. The first is the word no instead of not being incorrectly used. The second removes an extraneous m in the word embedded. I could not find any other PRs for this. I haven't changed any functionality, only the content of the declared error.

wgeorgecook commented 3 months ago

I know this is the smallest, least consequential thing, but I would be greatly appreciative if this could get merged in.

wgeorgecook commented 3 months ago

@tmc There are a lot of redeclared errors across the LLMs and Vectorstores. I could extract all of them into a shared errors package if that's helpful. Otherwise I can take both ErrIncompleteEmbeddings and ErrNoResponse that's shared with these LLMs and make them use a shared error.