search

tmc / pqstream

pqstream turns your postgres database into an event stream
MIT License
477 stars 24 forks source link

Remove gometalinter duplicated errcheck option and increase deadline #55

Closed joaodrp closed 7 years ago

joaodrp commented 7 years ago

The gometalinter errcheck is being enabled twice (--enable=errcheck argument) int the lint script (lines 9 and 19). Fixes issue #54

joaodrp commented 7 years ago

I also noticed that the default gometalinter deadline (30s) is not enough and the execution expires.

From https://circleci.com/gh/tmc/pqstream/292 (lint job):

WARNING: deadline exceeded by linter unconvert (try increasing --deadline)
WARNING: deadline exceeded by linter varcheck (try increasing --deadline)
WARNING: deadline exceeded by linter structcheck (try increasing --deadline)
WARNING: deadline exceeded by linter interfacer (try increasing --deadline)
WARNING: deadline exceeded by linter errcheck (try increasing --deadline)
WARNING: deadline exceeded by linter megacheck (try increasing --deadline)
WARNING: deadline exceeded by linter aligncheck (try increasing --deadline)
WARNING: deadline exceeded by linter gotype (try increasing --deadline)

So I added a --deadline=2moption to increase it to 2 minutes.

tmc commented 7 years ago

@joaodrp thanks for the contribution! this is already the slowest part of CI so I'm going to merge but probably open an issue to figure out a way to speed this up (perhaps dropping some lower-value linters).