tmccarthy / bfect

Some bifunctor IO type classes
Apache License 2.0
21 stars 2 forks source link

Operator extensions #17

Closed jchapuis closed 3 years ago

jchapuis commented 3 years ago

A proposal to add a couple of operators that I've been using when adapting our codebase:

There is no real coverage: I haven't found where I could integrate some tests for this. Were you actually considering defining some laws for the bifunctor typeclasses and running discipline tests? Maybe I could do a stab at this.

Cheers!

tmccarthy commented 3 years ago

There is no real coverage: I haven't found where I could integrate some tests for this. Were you actually considering defining some laws for the bifunctor typeclasses and running discipline tests? Maybe I could do a stab at this.

Yeah, this is an issue for this repository. The easiest way to start with some laws checking would be to do laws tests for the derived monofunctor cats instances. I've raised #9 to track this. So for example, you'd test that the cats.Monad derived from BifunctorMonad is lawful according to the cats discipline checks. This would be useful and gives some laws checking without having to define a whole ecosystem of laws for the bifunctor classes.

Any help with this would be much appreciated.

tmccarthy commented 3 years ago

Released as 0.5.0.