tmccoid-tech / extract-em

Extract 'Em!: email attachment extraction extension for Mozilla Thunderbird
https://addons.thunderbird.net/en-US/thunderbird/addon/extract-em
Mozilla Public License 2.0
4 stars 1 forks source link

Plenty of extraction errors Thunderbird 128.06 (Beta downloaded today) and Extract 'em! 1.3.1 (downloaded today) #16

Open ell1e opened 2 months ago

ell1e commented 2 months ago

I seem to be getting plenty of extraction errors when I run Extract 'em on my real world mails. Here are a few I see in the generated report:

Error: Type error for parameter partName (String "1.3$.2" must match /^\d+(\.\d+)*$/) for messages.getAttachmentFile.

Error: Part 1.1.1.2 not found in message 4871.

Error: Part 1.1.1.3 not found in message 4871.

Error: Part 1.1.1.2.2 not found in message 4799.

Error: Type error for parameter partName (String "1.2$.2" must match /^\d+(\.\d+)*$/) for messages.getAttachmentFile.

Error: Type error for parameter partName (String "1.2$.4" must match /^\d+(\.\d+)*$/) for messages.getAttachmentFile.

Embed Content-Type header not found (audit_bf_klein.jpg).

(Each error is for a different mail.)

I went to at least one of the messages with the "Part xxx not found" errors and checked, I can open the attachment in Thunderbird just fine so it's not like the attachment would legit actually be missing (in some way where it's corrupted on the server and Thunderbird itself wouldn't know how to get to it anymore).

Seen with Thunderbird version: Thunderbird 128.06 (Beta downloaded today)

Seen with Extract 'em! version: Extract 'em! 1.3.1 (downloaded today)

tmccoid-tech commented 2 months ago

What is happening here is that nested attachments are being incorrectly identified as first-level attachments. First-level attachments will have a part # such as 1.1.2 (three integers), where as nested attachments (such as those originating from a forwarded email) will have four or more integers.

This is actually a problem with the Thunderbird API (the code interface allowing extensions to communicate with Thunderbird) which I had reported some time back but which apparently has not been addressed.

I will contact the Thunderbird API team about the matter. Thanks for reporting the issue.

tmccoid-tech commented 2 months ago

The issue is being tracked at: messenger.messages.listAttachments: differing results between TB 102 and 115

tmccoid-tech commented 2 months ago

I communicated with the Thunderbird API team and they verified that the patch that should have prevented the error you are seeing above has been integrated as of TB 128.0b6. If you would be willing, could you do the following:

1) Execute the extension against the same set of emails that produced the errors you reported above 2) Locate the specific emails involved by using the Generate Report feature 3) Save those emails as .eml files, place them in a .zip file, and then add that file in a comment here (or email it to me)

If these emails contain sensitive information and you are unwilling to provide them, I understand.

Thanks.

ell1e commented 2 months ago

No problem, I sent you information. It's kind of private, but for internal investigation it should be fine. This extension is cool :tada: and I am happy to help out.