search

tmcgilchrist / ocaml-gitlab

Native OCaml bindings to Gitlab REST API v4
https://tmcgilchrist.github.io/ocaml-gitlab/gitlab/
BSD 3-Clause "New" or "Revised" License
27 stars 8 forks source link

add event tests for accepted and deleted actions #12

Closed patricoferris closed 3 years ago

patricoferris commented 3 years ago

A follow up for #9 adding the output for my Gitlab that was causing some issues when parsing the events. I just copied it over to the expected output, I didn't quite follow the jd testing setup, but dune runtest passes :)

tmcgilchrist commented 3 years ago

jd is giving a better JSON diff of the parsed output (doing a golden roundtrip tests), treating the JSON objects as sets. Comparing via diff or as OCaml ASTs wasn't great, a better AST diff library (even just for Polymorphic variants) would be nice.

Thanks.