search

tmcgilchrist / ocaml-gitlab

Native OCaml bindings to Gitlab REST API v4
https://tmcgilchrist.github.io/ocaml-gitlab/gitlab/
BSD 3-Clause "New" or "Revised" License
27 stars 8 forks source link

Update push data and remove unix dependency #9

Closed patricoferris closed 2 years ago

patricoferris commented 2 years ago

Hi Tim :))

Thanks for the great library, I'm planning on integrating it with okra (see: https://github.com/MagnusS/okra/pull/78) and when running it on my fairly sparse gitlab account the ATD runtime was throwing some errors for the action type of events. I'm a little confused because whilst the ones I added were present in the response, they're not in the docs :// Do you know if I was just doing something wrong?

The other change is to remove the unix dependency from the core Gitlab library. We use the Okra library with jsoo so it would be great if we can make this change?

Thanks again

tmcgilchrist commented 2 years ago

Unfortunately I've found the docs out of date in various places, so I've been basing my code loosely off docs and then running queries against gitlab.com to get more sample data.

If you have the event_action responses available, there is a test file at event.json that includes sample responses from my GitLab activity. Could you add examples of the new events there?

The changes look good, thank you. If there is anything missing that would be helpful please open an Issue.

patricoferris commented 2 years ago

Thanks for merging!

Yep, will follow up with the tests shortly :))